Refactor: Introduce EnvManager for structured environment variable handling#194
Merged
Refactor: Introduce EnvManager for structured environment variable handling#194
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
=====================================
Coverage 4.87% 4.87%
=====================================
Files 28 28
Lines 820 820
=====================================
Hits 40 40
Misses 780 780 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a comprehensive
EnvManagersystem to replace the simpleenvEnable()function with structured, testable, and maintainable environment variable management.Key Features
1. Domain-based Variable Lookup
OPENATTRIBUTEGRAPH_*,OPENSWIFTUI_*)includeFallbackToRawKeyoptionDEVELOPMENTinstead ofOPENATTRIBUTEGRAPH_DEVELOPMENT2. Multiple Value Types
envBoolValue()- Boolean environment variables (0/1)envIntValue()- Integer environment variablesenvStringValue()- String environment variables3. Testability & Flexibility
EnvironmentProviderprotocolreset()method for test cleanupwithDomain()for temporary domain contexts4. Enhanced Debugging
Environment Variable Changes
All environment variables now use shorter names with automatic domain prefixing:
OPENATTRIBUTEGRAPH_DEVELOPMENTDEVELOPMENTOPENATTRIBUTEGRAPH_*,OPENSWIFTUI_*OPENATTRIBUTEGRAPH_WERRORWERROROPENATTRIBUTEGRAPH_LIBRARY_EVOLUTIONLIBRARY_EVOLUTIONOPENATTRIBUTEGRAPH_COMPATIBILITY_TESTCOMPATIBILITY_TESTOPENATTRIBUTEGRAPH_USE_LOCAL_DEPSUSE_LOCAL_DEPSOPENATTRIBUTEGRAPH_ATTRIBUTEGRAPHATTRIBUTEGRAPHBenefits
withDomain()Testing